REF: Make CategoricalIndex comparison defer to Categorical comparison #27769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
API Design
Categorical
|
looks fine; are the added paths hit in coverage? e.g. do we need any additional tests? |
|
The new paths are all hit, yes. |
|
thanks @jbrockmendel |
| elif ( | ||
| is_list_like(other) | ||
| and len(other) != len(self) | ||
| and not isinstance(other, (set, frozenset)) |
There was a problem hiding this comment.
@jbrockmendel maybe by accident due to several PRs that were related / rebase after each other, but this seemingly introduced again what you removed in #27873 (although the other PR was merged later ..)
No matter how it happened ;), the check is still in master ..
There was a problem hiding this comment.
yah this looks like a rebase screwup, will address
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #19513.
After this, CategoricalIndex will be defining comparison ops identically to DTA/TDA/PA, could share some code.